Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Koa version #58

Closed
pspeter3 opened this issue Apr 25, 2014 · 7 comments
Closed

Koa version #58

pspeter3 opened this issue Apr 25, 2014 · 7 comments

Comments

@pspeter3
Copy link

I can imagine the desire for something supports the feathers service api but with Koa. Do you guys have thoughts on this?

@daffl
Copy link
Member

daffl commented Apr 25, 2014

Implementing the REST wrapper for Koa shouldn't be too hard I'd wait until ES6 makes it into Node stable though. Koa only works with 0.11 and the --harmony flag (for the generators). What would be interesting is to see how the Feathers high level concepts could benefit from ES6. Having things like Promises, Proxies and Classes baked in could definitely make things easier:

class TodoService {
  constructor (app, path) {
    this.app = app;
  }

  find (params) {

  },

  get (id) {
    return new Promise((resolve, reject) => {
      resolve({
        id: id,
        description: 'You have to do ' + id
      });
    });
  },

  create (data, params) {

  },

  update (id, data, params) {

  },

  patch (id, data, params) {

  },

  remove (id, params) {

  }
}

@pspeter3
Copy link
Author

pspeter3 commented May 5, 2014

Yeah for sure, I'm excited for this future.

@pspeter3 pspeter3 closed this as completed May 5, 2014
@Glavin001
Copy link
Contributor

@pspeter3 you could make the Koa support as a Feathers Plugin? See generator-feathers-plugin. I have not used Koa before, but looking at its docs it looks like a great framework!

@safizn
Copy link

safizn commented Feb 23, 2017

I wish you had Koa support. Its an amazing framework limiting it to Express isn't.
Thanks

@marshallswain
Copy link
Member

marshallswain commented Feb 23, 2017

@myuseringithub you can try using @daffl's comment to create an adapter. We haven't seen that Koa provides us with anything that we can't do with the current Express version, but if you see the need, please fill it. We will be as supportive of your work as we possibly can with what time we have.

@safizn
Copy link

safizn commented Feb 26, 2017

Thanks @marshallswain , currently I won't use feathers. I think it adds an abstraction layer, that I don't like. I'm turning into building server with pure nodejs, as it gives more control. & I've implemented a simple version of CRUD REST API for Rethinkdb that fits my needs.
Would really like to see feathers as separated modules that are added as a supplement to the main server/app not a framework that should be extended and will end up being the app itself.
Still learning, maybe afterward will have a different view or would see more options.

@lock
Copy link

lock bot commented Feb 7, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants