Tests for socket message validation and errors. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks all good! |
ekryski
added a commit
that referenced
this pull request
Mar 6, 2015
Tests for socket message validation and errors.
|
I love the validation! It's good to see the server still running after doing something stupid. |
|
I might refactor this as a general mixin that doesn't just do this for sockets but for all service method calls all the time (so you can also use this with |
daffl
added a commit
that referenced
this pull request
Aug 25, 2018
Remove typo, update year in generated README
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for the latest feathers-commons functionality which allows Socket message validation and to omit parameters and calls back with an error when wrong arguments are submitted. Closes #96 and closes #113. /cc @marshallswain