Correct HooksObject typing due to normalization; add finally #1300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request does 2 things:
HookMap
(akaall
,find
, etc)The standardization of the object occurs here:
feathers/packages/commons/src/hooks.ts
Lines 69 to 85 in 656bae7
finally
method to typingsThe code enabling this is in a few places throughout the file, but can be seen here:
feathers/packages/feathers/lib/hooks/index.js
Lines 156 to 159 in 3ad094e
No, I didn't see any
No
Other Information
I noticed
finally
is not listed in the docs: https://docs.feathersjs.com/api/hooks.html#registering-hooksIf it is not encouraged and will be removed in a future release, I suggest we add
@deprecated
, otherwise I believe it should be added as-is.I added a PR for "DefinitelyTyped" here DefinitelyTyped/DefinitelyTyped#34897