Skip to content

finally should be optional #1350

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 15, 2019
Merged

finally should be optional #1350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b6cfe8
finally should be optional
bitflower May 10, 2019
7990cc7
Remove outdated comment
daffl May 14, 2019
4eef6ab
Merge branch 'master' into master
daffl May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/feathers/index.d.ts
View file
Original file line number Diff line number Diff line change
@@ -133,7 +133,7 @@ declare namespace createApplication {
before: Partial<HookMap> | Hook | Hook[];
after: Partial<HookMap> | Hook | Hook[];
error: Partial<HookMap> | Hook | Hook[];
finally: Partial<HookMap> | Hook | Hook[];
finally?: Partial<HookMap> | Hook | Hook[];
}

// todo: figure out what to do: These methods don't actually need to be