Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Add params.authentication type, remove hook.connection type #1732

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/authentication/src/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ declare module '@feathersjs/feathers' {

interface Params {
authenticated?: boolean;
authentication?: AuthenticationRequest;
}
}

Expand Down
4 changes: 0 additions & 4 deletions packages/feathers/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,6 @@ declare namespace createApplication {
* A read only property with the hook type (one of before, after or error).
*/
readonly type: 'before' | 'after' | 'error';
/**
* The real-time connection object
*/
connection?: any;
}

interface HookMap {
Expand Down