Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(express): missing express types for Request, Response #2498

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

marshallswain
Copy link
Member

Fixes this issue:
Screen Shot 2021-11-26 at 9 47 53 AM

@daffl daffl changed the title fix: missing express types for Request, Response fix(express): missing express types for Request, Response Nov 26, 2021
@daffl
Copy link
Member

daffl commented Nov 26, 2021

As I mentioned, we might want to look into why this didn't break the tests before. I think it's because Response and Request are also global variables in the Web API. If so we should disable them here.

@daffl daffl merged commit ee67131 into dove Nov 26, 2021
@daffl daffl deleted the fix-express-types branch November 26, 2021 17:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants