Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(schema): test for using a custom AJV with ajv-formats #2513

Merged
merged 4 commits into from
Jan 3, 2022

Conversation

marshallswain
Copy link
Member

@marshallswain marshallswain commented Dec 22, 2021

Summary

  • Adds a test that shows how to use ajv-formats with a custom instance of Ajv. I opted for leaving the ajv-formats package out and created a test that shows using a custom instance of Ajv with the extra formatters.
  • Allows passing custom ajv instance to the schema function. This might be the only change we really want. Then I can write some docs on how to customize AJV and provide it as the second function.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
marshallswain Marshall Thompson
@marshallswain marshallswain changed the title feat(schema): add ajv-formats feat(schema): test for using a custom AJV with ajv-formats Dec 22, 2021
@marshallswain marshallswain requested a review from daffl December 22, 2021 20:08
marshallswain and others added 3 commits December 22, 2021 22:57

Verified

This commit was signed with the committer’s verified signature.
marshallswain Marshall Thompson

Verified

This commit was signed with the committer’s verified signature.
marshallswain Marshall Thompson
@daffl daffl merged commit ecfa4df into dove Jan 3, 2022
@daffl daffl deleted the schema-add-formats branch January 3, 2022 22:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants