Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add instructions for handling CORS for sockets #2703

Closed
wants to merge 1 commit into from

Conversation

blackmann
Copy link

Summary

Since v3 of socket.io cors options need to be explicit. https://socket.io/docs/v3/handling-cors/

I spent about two hours figuring out what's happening; I think it'll be helpful to others in future if the docs stated how to handle it.

  • Tell us about the problem your pull request is solving.
  • Are there any open issues that are related to this?
  • Is this PR dependent on PRs in other repos?

@netlify
Copy link

netlify bot commented Jul 24, 2022

Deploy Preview for feathers-dove failed.

Name Link
🔨 Latest commit 223e938
🔍 Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/62dda5350c2168000ae6856b

@daffl
Copy link
Member

daffl commented Aug 3, 2022

Hm... this is a good point, I'm wondering if the CLI should do more here and ask for the origin urls.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants