Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(schema): init typebox schema #2762

Closed
wants to merge 1 commit into from

Conversation

fratzinger
Copy link
Member

@fratzinger fratzinger commented Sep 26, 2022

@noor-tg
Copy link

noor-tg commented Sep 29, 2022

would you describe the details about this change ?

@fratzinger
Copy link
Member Author

Sorry for the confusion! This PR is about tinkering. It's something @daffl and I have discussed.
We want to see if Typebox could be a way to define the new JSON schemas in feathers v5. I've tried it in the feathers-chat repo and wanted to share it with @daffl, so he can elaborate if there's a fit for feathers.js.

How come you're interested in this PR @Nour-DEV? I'm interested in your thoughts.

@noor-tg
Copy link

noor-tg commented Sep 29, 2022

Sorry for the confusion! This PR is about tinkering. It's something @daffl and I have discussed.
We want to see if Typebox could be a way to define the new JSON schemas in feathers v5. I've tried it in the feathers-chat repo and wanted to share it with @daffl, so he can elaborate if there's a fit for feathers.js.

How come you're interested in this PR @Nour-DEV? I'm interested in your thoughts.

I don't know the context of the pull request . So I asked about the details. So I can't evaluate it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants