fix(core): Run after all hooks first, and then after method hooks #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | f771955 |
daffl
changed the title
daffl
approved these changes
Jan 28, 2023
|
Thank you for looking into this. I can't believe we didn't have a test covering that. I was trying a few things to see if there was a different fix but I think this will have to be it for now. The fun and not-so-fun fact here is that a lot of that code is for backwards compatibility for a very specific case which is being able to call |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3002 - bring back the "after all" and "after method" hook ordering from V4.
The implementation is not as neat as it was before (having just 1 set of collected hooks was a nice idea). Let me know if you have a better idea.