-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixes #121
base: main
Are you sure you want to change the base?
Fixes #121
Conversation
SETUP.md
Outdated
``` | ||
|
||
2. Before installing other Python requirements, you need to install Apache httpd first. Follow the instructions from [mod-wsgi project documentation](https://pypi.org/project/mod-wsgi/). | ||
<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mod-wsgi documentation says that for installation of the module we need to have Apache installed first. During installation on MacOS, mod-wsgi was erroring out, brew installing httpd resolved the issue. But yeah, this might've been the issue just with my system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be different for MacOS vs Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be different for MacOS vs Linux.
Signed-off-by: rdotjain <rupanshijain45678@gmail.com>
Signed-off-by: rdotjain <rupanshijain45678@gmail.com>
Signed-off-by: rdotjain <rupanshijain45678@gmail.com>
Overall this looks fine, I would improve the commit messages and update the PR and remove draft. |
thanks for the review @nullr0ute As this PR was doing multiple things, I opened a new PR #133 to particularly resolve "forget device" issue #88 and I think we can further refine the setup guide before merging this one. |
(1444c2e) Fixes #107 Added a getting started documentation.
(4086909) Fixes #110 General improvements for the device management tab.
(0108046) Fixes #88 Add option to 'forget' devices waiting to be claimed or already claimed