Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sharness: add option -x from Git's test-lib #91

Merged
merged 6 commits into from
Jun 27, 2019
Merged

sharness: add option -x from Git's test-lib #91

merged 6 commits into from
Jun 27, 2019

Conversation

chriscool
Copy link
Collaborator

This option can help a lot in debugging tests, as it shows
the last shell command that was executed.

It's especially useful along with -i and -v.

@chriscool
Copy link
Collaborator Author

chriscool commented Apr 29, 2019

This PR is based on top of #90 for now as I plan to merge #90 first.

This needs tests.

@chriscool
Copy link
Collaborator Author

Actually there is something wrong with this, as it doesn't seem to work...

@chriscool chriscool changed the base branch from lib-sharness-functions to master May 27, 2019 09:11
@chriscool
Copy link
Collaborator Author

This works now. I plan to add tests, wait a bit for comments and then merge into master (now that lib-sharness-functions has been merged).

This option can help a lot in debugging tests, as it shows
the last shell command that was executed.

It's especially useful along with -i and -v.
When using -x this useless call to test_eval_() makes us
print a useless debug line with only "+ :".
@chriscool
Copy link
Collaborator Author

I just rebased on top of master and added 2 commits that improve things a bit.

I plan to merge this really soon now :-)

@chriscool
Copy link
Collaborator Author

I had to massage the test a little bit, but I think everything is well now \o/

@chriscool chriscool merged commit 28c7490 into master Jun 27, 2019
@felipec felipec deleted the option-x branch March 10, 2023 05:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant