Skip to content

Autocomplete member selectivity #607

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

Declspeck
Copy link
Contributor

This removes completions for TestClass::SOMETHING_ELSE when completing for TestClass::NOT_SOMETHING_ELS|. Same for -> completions.

This is based on #599 so this cannot be merged before that, and only the last commit contains any meaningful changes.

@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #607 into master will increase coverage by 0.31%.
The diff coverage is 90.55%.

@@             Coverage Diff              @@
##             master     #607      +/-   ##
============================================
+ Coverage     81.63%   81.94%   +0.31%     
- Complexity      910      947      +37     
============================================
  Files            61       61              
  Lines          2075     2227     +152     
============================================
+ Hits           1694     1825     +131     
- Misses          381      402      +21
Impacted Files Coverage Δ Complexity Δ
src/Server/TextDocument.php 75.55% <100%> (+0.18%) 57 <0> (+1) ⬆️
src/Index/AbstractAggregateIndex.php 86.04% <71.42%> (-7.44%) 26 <6> (ø)
src/Index/Index.php 77.41% <82.5%> (+7.6%) 54 <32> (+32) ⬆️
src/FqnUtilities.php 83.87% <90.47%> (+13.87%) 0 <0> (ø) ⬇️
src/CompletionProvider.php 94.24% <96.69%> (-0.27%) 112 <73> (+4)

@felixfbecker
Copy link
Owner

Is this still relevant?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants