Skip to content

fix: Update reflection-docblock for broken handling of phpstorm-stubs and deprecated method. #823

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

zobo
Copy link

@zobo zobo commented Aug 31, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #823 (ecf0374) into master (9dc1656) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head ecf0374 differs from pull request most recent head a7e2f9a. Consider uploading reports for the commit a7e2f9a to get more accurate results

@@             Coverage Diff              @@
##             master     #823      +/-   ##
============================================
- Coverage     82.12%   81.87%   -0.26%     
- Complexity      935      937       +2     
============================================
  Files            44       44              
  Lines          2154     2135      -19     
============================================
- Hits           1769     1748      -21     
- Misses          385      387       +2     
Impacted Files Coverage Δ
src/DefinitionResolver.php 87.47% <100.00%> (+0.02%) ⬆️
src/Cache/FileSystemCache.php 15.00% <0.00%> (-5.00%) ⬇️
src/Index/AbstractAggregateIndex.php 81.39% <0.00%> (-4.66%) ⬇️
src/Indexer.php 56.96% <0.00%> (-1.27%) ⬇️
src/LanguageServer.php 77.35% <0.00%> (-0.52%) ⬇️
src/PhpDocumentLoader.php 92.50% <0.00%> (-0.19%) ⬇️
src/TreeAnalyzer.php 94.23% <0.00%> (-0.06%) ⬇️
src/SignatureInformationFactory.php 100.00% <0.00%> (ø)
src/CompletionProvider.php 94.44% <0.00%> (+0.19%) ⬆️

@guoyunhe
Copy link

guoyunhe commented Nov 6, 2021

Hope you can merge this PR. The VS Code plugin is unusable now.

@zobo
Copy link
Author

zobo commented Nov 6, 2021

Hi @guoyun. This plugin has been de-listed from the marketplace. I have re-published it under the same name with my ID. If you see issues, please open them here https://github.com/zobo/php-language-server/issues

@jmdaemon
Copy link

Hello is there anyone available to merge this PR or is there something else that needs to be done before then?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants