Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support Windows #2

Closed
felixge opened this issue Sep 20, 2022 · 1 comment · Fixed by #4
Closed

Support Windows #2

felixge opened this issue Sep 20, 2022 · 1 comment · Fixed by #4
Labels
bug Something isn't working

Comments

@felixge
Copy link
Owner

felixge commented Sep 20, 2022

gostackparse has a bug causing error messages like this on windows: invalid file:line ref on line 3: \"\\tC:/Users/felixge/pprof.go:693 +0x9f\"

Should be relatively easy to fix in the upstream package.

Thanks to @lkarlslund for reporting on twitter.
@felixge felixge added the bug Something isn't working label Sep 20, 2022
@felixge felixge mentioned this issue Sep 21, 2022
Merged
felixge added a commit that referenced this issue Sep 21, 2022
@felixge
Merge pull request #4 from felixge/gh-2-support-windows
857467a 
fix: support windows
@lkarlslund
Copy link

Can confirm that this works great. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support windows felixge/fgtrace
2 participants
@felixge @lkarlslund