-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
upgpatch: v2ray #3139
upgpatch: v2ray #3139
Conversation
Resolved `go test` error; however, due to the current incompatibility of v2ray-core 5.7.0 with go version 1.21, the compilation is still failing. This patch has been reported to the upstream as issue [v2ray/v2ray-core#2720](v2fly/v2ray-core#2720)
Thanks for the work! But do you mean it still does not compile with this updated patch? If so, I would suggest you try to fix it together in this PR. After all, a patch that doesn't work is not much meaningful. :P
I'm wondering why do you create an issue with a patch instead of a PR. 🤔 |
emm, I've only fixed the problem with the code itself so far, the compilation error is because the upstream hasn't been updated to v5.8.0 . You can check the logs here, the error I fixed is the one in the logs. But since there is no update upstream (I updated locally to v5.8.0 for testing), so it compile fail. I started out just trying to fix the bug. But I realized that because of the incompatibility of the dependencies downloaded at compile time due to an upstream version change. Fortunately, the upstream has resolved the issue, I can I can fix the bug locally. Sorry, my expressive ability is not particularly good, so if you have any questions please contact me right away. |
Then from archriscv side, just waiting for Arch to upgrade should be OK. Also we can make an Arch bug report that it's FTBFS with the new golang.
TBH I don't see any compile error from the log. Do you mean the failing check?
No worries at all! Actually you expressed clearly! |
Yep, is the failing check. I just fix those errors. Since go was recently updated to 1.21, v2ay can't be compiled, although v2ray developers have solved this issue, but it's still in pre-realese. if the compilation succeeds and my patch is added, the check fail in the log I mentioned above will be solved. Actually, my patch only solves the check fail problem. So we have to wait for the upstream update, right?
|
Yeah. And you can also create a bug report to Arch. |
Thank you for your patience. Do I need to close this pr? |
No problem. You may leave it open and we can merge it after Arch upgrades. |
Resolved
go test
error; however, due to the current incompatibility of v2ray-core 5.7.0 with go version 1.21, the compilation is still failing.This patch has been reported to the upstream as issue v2ray/v2ray-core#2720