Migrate to new bring library #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UUID field is now generated dynamically in the `to_dict` method instead of being set during initialization.
Updated the `EnvironmentVariableGetter.get` method to accept an optional `default_value` parameter. If the specified environment variable is not set, the method now returns the provided default value instead of raising an error.
This was referenced Jan 26, 2025
Introduced `IngredientWithAmountsDisabled` to process ingredients when amounts are not enabled. Updated the ingredient parsing logic to conditionally handle ingredients based on the `enable_amount` flag.
felixschndr
force-pushed
the
feat/migrate-bring-library
branch
from
4f5d64b to
0b72c5c
Compare
|
This has a bug I noticed I few days ago. I will fix it when I find some time, probably next week. Afterwards I will merge it and then work on #15 |
Added an important notice in the README to clarify that the integration only supports Mealie version 2 or higher, released in October 2024. Deprecated support for earlier versions is also mentioned with a reference to the relevant pull request.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from the old unmaintained python-bring-api to a new version of the library.
Benefits:
NoodelsandNoodelsandNoodels 200gandNoodles 500gandNoodles (or rice)to the same listI tested it with my data in Mealie. Feel free to do so yourself by using the image
ghcr.io/felixschndr/mealie-bring-api:feat-migrate-bring-library. I am happy to hear from you about any feedback or issues.Warning
This deprecates the support for Mealie version < 2