Fix: wrong paths generated for @local/@preview packages
#30
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofabilous
force-pushed
the
fix-packages
branch
from
d242eef to
a00ad88
Compare
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these changes, typst packages could not be imported.
SystemWorld::prepare_packageto represent the current structure of packages (namespace/name/version), which allows typst to find and detect the existence of packages (before this, importing packages resulted in a "package not found" error)path.normalize()in place ofobsidian.normalizePath()inpreparePackage(), because the latter always interprets paths as being relative to the vault, but namespaced packages (i.e.@local/@preview) always refer to paths outside of the vault