Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update TinyGo docs to reflect statics fix #1451

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

itowlson
Copy link
Contributor

This reflects a template update.

Do not merge until the template becomes current (probably v3.2).

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the tinygo-build-args-statics-fix-update branch from e4258fb to d868b37 Compare January 13, 2025 00:11
@itowlson itowlson requested a review from adamreese January 13, 2025 01:28
@mikkelhegn
Copy link
Member

Is anything blocking this from review and merge?

@mikkelhegn
Copy link
Member

@adamreese

@itowlson
Copy link
Contributor Author

itowlson commented Jan 26, 2025

@mikkelhegn

Do not merge until the template becomes current (probably v3.2).

But yes should be ready for review (Adam, I updated to reflect your fixes to the TinyGo build command)

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the tinygo-build-args-statics-fix-update branch from 68a344f to 8fdec56 Compare January 26, 2025 20:27
Copy link
Member

@adamreese adamreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants