Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TinyGo SQLite to the API guide #883

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

adamreese
Copy link
Member

TinyGo SQLite will be released in Spin 1.5


**General Notes**

A convince function `sqlite.Open()` is provided to create a database connection. Because the `http.Handle` function is inside the `init()` function the Spin SQLite driver cannot be initialized the same way as other drivers using [sql.Open](https://pkg.go.dev/database/sql#Open).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A convince function `sqlite.Open()` is provided to create a database connection. Because the `http.Handle` function is inside the `init()` function the Spin SQLite driver cannot be initialized the same way as other drivers using [sql.Open](https://pkg.go.dev/database/sql#Open).
A convenience function `sqlite.Open()` is provided to create a database connection. Because the `http.Handle` function is inside the `init()` function the Spin SQLite driver cannot be initialized the same way as other drivers using [sql.Open](https://pkg.go.dev/database/sql#Open).

Almost had me convinced

Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdice
Copy link
Member

vdice commented Sep 13, 2023

@adamreese I just realized we also have a language support guide here in this repo (in addition to the README.md in fermyon/spin); would you mind updating this line as well? https://github.com/fermyon/developer/blob/main/content/spin/language-support-overview.md?plain=1#L88

Signed-off-by: Adam Reese <adam@reese.io>
@adamreese adamreese merged commit e734719 into fermyon:main Sep 13, 2023
@adamreese adamreese deleted the tinygo-sqlite branch September 13, 2023 22:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants