This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Update Spin adapter module #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
This was referenced Sep 8, 2023
lann
approved these changes
Sep 8, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fermyon/spin#1748 discovered that what's currently on main does not work. This change updates the spin adapter module to a working version.
The diff between the adapter module in main and the one this PR introduces: [diff]
The diff between upstream wasmtime commit this is based on and the changes made specifically for spin: [diff]
The only thing I'm unsure of at this point is why the tests don't fail on the current main - we should figure that out so that mistakes like this don't happen again. cc @dicej