This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Pass through any 0.x version of wit-bindgen great than 0.4 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
dicej
approved these changes
Oct 19, 2023
| Some(v) if v.starts_with("0.8.") => return Ok(Self::V0_8), | ||
| Some(other) => return Ok(Self::Other(other.to_owned())), | ||
| None => {} | ||
| if let Some(v) = bindgen_version { |
There was a problem hiding this comment.
Could consider using https://crates.io/crates/semver for this.
There was a problem hiding this comment.
Seems a bit overkill for now, but if we run into issues I'll switch over.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of locking on a single version, I think we can just let anything through as long as its wit-bindgen 0.5 or newer based. This should prevent us from needing to update spin-componentize with each new wit-bindgen release. I'm still being somewhat conservative and erroring on any major version 1 and above. We can revisit that when the time comes.