-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: add tools directory and include modsurfer #1190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @nilslice! It all looks good but one question I have is how to maintain and version it. For example, at some future date, Spin HEAD will presumably go to WASI Preview 2. How will we ensure these files are updated in sync? And, even more importantly, how will users who are on older (released) builds ensure they are validating against their runtime instead of HEAD? We don't need to thrash out a process in detail but I'd like to have some sense of what day two operations looks like...
Great question! The One of the benefits of end-users tracking validate:
imports:
namespace:
include:
- wasi_snapshot_preview2
exclude:
- wasi_snapshot_preview1 # <--- this will break builds if users are not up to date It also occurred to me that these files could go into the templates themselves... it may be something to consider in the future, and I'd be happy to collaborate on that. Note that these files were generated by using the Modsurfer CLI:
So if you ever need to update them, and want to give it a shot yourself, you can use a built Spin wasm module as a starting point and have the checkfile created for you. |
@itowlson Hello, sir! Following up on this, as I just saw the Fermyon Cloud deployer GitHub Action news today... what better to complement that than with a pre-deploy validation check? 😄 |
Ah! I was thinking just last night that I needed to get back to this, then morning came and I completely forgot. Thank you for the prompt! |
Oh, but you need to GPG sign the commit, sorry |
Signed-off-by: Steve Manuel <steve@dylib.so>
Force-pushed to override with the signed commit. Thanks! |
In reference to #1120, this PR includes a
tools
directory along with the contents of themodsurfer
directory within it. I am happy to update this PR according to any other location in the repo at your suggestion!I've tested that the remote reference to a Spin checkfile works as documented in the README here, and will update the Modsurfer workflows to use these same remotes as soon as the PR is merged.
Closes #1120