docs: Add branch creation to release process #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
approved these changes
Mar 10, 2023
vdice
reviewed
Mar 10, 2023
| 1. If this is the first release for this major/minor version, create a release | ||
| branch e.g. `v2.0`. With our branch protection rules this is easiest from | ||
| the Github UI with the | ||
| [New Branch button here](https://github.com/fermyon/spin/branches). |
There was a problem hiding this comment.
Shall we update the next line to explictly mention "Check out the v* branch created above and create a new tag with the same name..."?
Optional: I wonder if we should also mention specific commands/steps for the tag creation bit. We could opt for cli (git tag v* && git push origin v*) -- also do we want to start signing and/or annotating the tag? -- or maybe we opt for a UI-based approach?
There was a problem hiding this comment.
I'd say if we're going to add any more complexity to the process at this point we should script it.
There was a problem hiding this comment.
Added "switch to the release branch locally"
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
add-release-branch-process
branch
from
6f92ee5 to
2709c80
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.