Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: Add backport workflow #1275

Merged
merged 1 commit into from
Mar 15, 2023
Merged

ci: Add backport workflow #1275

merged 1 commit into from
Mar 15, 2023

Conversation

lann
Copy link
Collaborator

@lann lann commented Mar 15, 2023

This will allow merged PRs to be automatically backported to a release
branch via either a label (before the original PR is merged) or a
comment.

Uses:
https://github.com/marketplace/actions/backport-merged-pull-requests-to-selected-branches

This will allow merged PRs to be automatically backported to a release
branch via either a label (before the original PR is merged) or a
comment.

Uses:
https://github.com/marketplace/actions/backport-merged-pull-requests-to-selected-branches

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann force-pushed the ci-backport-workflow branch from c36a763 to a5f3428 Compare March 15, 2023 20:03
@lann lann changed the title Ci backport workflow ci: Add backport workflow Mar 15, 2023
@itowlson
Copy link
Contributor

itowlson commented Mar 15, 2023

Does the slash command need to say what branch to backport onto, or does it Just Know? Never mind, saw your command about the branch name in Slack

@lann
Copy link
Collaborator Author

lann commented Mar 15, 2023

Hmm...for some reason I thought you would specify /backport <branch> but after a closer look I think you actually have to add the label and then trigger it with the comment (if you already merged).

@itowlson
Copy link
Contributor

I guess we need another action to add the label then. </deadpan>

Copy link
Member

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Will wanna add some guidance to the release process around this once we've tested it out.

Also, we might want to consider that the /backport comment might be abused where as we can set permissions for who can add labels.

@lann lann merged commit 784c611 into fermyon:main Mar 15, 2023
@lann lann deleted the ci-backport-workflow branch March 15, 2023 20:19
@lann
Copy link
Collaborator Author

lann commented Mar 15, 2023

/backport

@github-actions
Copy link
Contributor

Successfully created backport PR for v1.0:

@lann
Copy link
Collaborator Author

lann commented Mar 15, 2023

Also, we might want to consider that the /backport comment might be abused where as we can set permissions for who can add labels.

I don't think the action does anything that a user couldn't do manually, so we should be OK.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants