Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

http: add spin-client-addr header #1298

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

psarna
Copy link
Contributor

@psarna psarna commented Mar 16, 2023

Inspired by the outcome of #1297, this commit adds a spin-client-addr header, which exposes the sender's IP address of a request to SDK users.

@psarna
Copy link
Contributor Author

psarna commented Mar 16, 2023

@itowlson thanks so much for the suggestion in #1297, this solution is actually so much more elegant than trying to inject the address into the .wit interfaces.

@itowlson
Copy link
Contributor

@psarna I'm afraid we need commits to be GPG signed before we can merge them - sorry the automation didn't pick this up earlier - would you be able to do that and re-push please? Thanks!

https://docs.github.com/articles/about-gpg/

Inspired by the outcome of fermyon#1297, this commit
adds a `spin-client-addr` header, which exposes
the sender's IP address of a request to SDK users.

Signed-off-by: Piotr Sarna <sarna@chiselstrike.com>
@psarna psarna force-pushed the spin-client-addr branch from cb92986 to 2004b14 Compare March 17, 2023 05:14
@psarna
Copy link
Contributor Author

psarna commented Mar 17, 2023

@itowlson sure, just did!

@itowlson itowlson merged commit 9384cd9 into fermyon:main Mar 17, 2023
@itowlson
Copy link
Contributor

Thank you for contributing @psarna!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants