Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(templates): update sdk to v1.0.0 #1316

Merged
merged 1 commit into from
Mar 21, 2023
Merged

feat(templates): update sdk to v1.0.0 #1316

merged 1 commit into from
Mar 21, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Update the SDK version used by the templates

Signed-off-by: fermybot <103076628+fermybot@users.noreply.github.com>
@fibonacci1729 fibonacci1729 requested a review from vdice March 21, 2023 18:52
@vdice
Copy link
Member

vdice commented Mar 21, 2023

We can either merge this to main as currently config'd and backport to v1.0 or merge into v1.0 and then do the same updates manually on main. The changes themselves would obviously be equivalent but the automated templates tag generation that occurs after the merge event differs (for the former, a tag is cut from main, the latter v1.0).

Technically we'd want the tag to be cut on v1.0, in case there were any unreleased template or sdk changes on main not intended for the release branch. So, I've updated the base to v1.0. I can help with a follow-up PR to rev the versions on main. Okay, so I tried updating the base to v1.0 but then the commits were crazy with conflicts. I think we'll have to go back to the drawing board on how we'll want to do this properly. In this case, there aren't any new template or SDK changes between main and v1.0, so we're good to merge to main and backport.

@vdice vdice changed the base branch from main to v1.0 March 21, 2023 19:14
@vdice vdice changed the base branch from v1.0 to main March 21, 2023 19:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants