-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
sip: Add runtime config section to Key-Value SIP #1352
Conversation
Do you want to account for user-provided environment variables that specify conection to the keyvalue store? An example would be the azure blob storage config in spiderlightning https://github.com/deislabs/spiderlightning/blob/main/examples/keyvalue-demo/keyvalue_azblob_slightfile.toml#L14-L15 |
Environment variables or the Spin configuration system (or both)? |
Injecting config variables into KV store config is definitely on my radar, but there are some operational subtleties to consider around access control, e.g. if an SRE wanted to use a Vault config provider to set my Redis KV password, should that config value be available in app configs as well? Seems like it shouldn't need to be, but we either need a way to deal with that scenario or decide its ok. |
I am not familiar with spin configuration system. What's that?
Forgive my ignorance on this field, but couldn't the Vault config value be injected as environment variables to the host and thus be feeded into the app configs which specify what env vars are needed? |
|
Yes, but I'm thinking of a scenario where you don't want a secret exposed to an app. Say if an organization has an operations group responsible for administering infrastructure that wants to provide a Redis-backed KV implementation to an applications group, but doesn't want to expose the Redis password to applications. |
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
No description provided.