Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sip: Add runtime config section to Key-Value SIP #1352

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

lann
Copy link
Collaborator

@lann lann commented Apr 4, 2023

No description provided.

@lann lann requested review from dicej and kate-goldenring April 4, 2023 18:15
@Mossaka
Copy link
Contributor

Mossaka commented Apr 4, 2023

Do you want to account for user-provided environment variables that specify conection to the keyvalue store?

An example would be the azure blob storage config in spiderlightning https://github.com/deislabs/spiderlightning/blob/main/examples/keyvalue-demo/keyvalue_azblob_slightfile.toml#L14-L15

@radu-matei
Copy link
Member

radu-matei commented Apr 4, 2023

Environment variables or the Spin configuration system (or both)?

@lann
Copy link
Collaborator Author

lann commented Apr 4, 2023

Injecting config variables into KV store config is definitely on my radar, but there are some operational subtleties to consider around access control, e.g. if an SRE wanted to use a Vault config provider to set my Redis KV password, should that config value be available in app configs as well? Seems like it shouldn't need to be, but we either need a way to deal with that scenario or decide its ok.

@Mossaka
Copy link
Contributor

Mossaka commented Apr 4, 2023

Environment variables or the Spin configuration system (or both)?

I am not familiar with spin configuration system. What's that?

if an SRE wanted to use a Vault config provider to set my Redis KV password, should that config value be available in app configs as well?

Forgive my ignorance on this field, but couldn't the Vault config value be injected as environment variables to the host and thus be feeded into the app configs which specify what env vars are needed?

@lann
Copy link
Collaborator Author

lann commented Apr 5, 2023

I am not familiar with spin configuration system. What's that?

https://developer.fermyon.com/spin/dynamic-configuration

@lann
Copy link
Collaborator Author

lann commented Apr 5, 2023

couldn't the Vault config value be injected as environment variables to the host and thus be feeded into the app configs which specify what env vars are needed?

Yes, but I'm thinking of a scenario where you don't want a secret exposed to an app. Say if an organization has an operations group responsible for administering infrastructure that wants to provide a Redis-backed KV implementation to an applications group, but doesn't want to expose the Redis password to applications.

michelleN

This comment was marked as resolved.

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann force-pushed the kv-runtime-config branch from edc9053 to f1bf008 Compare April 5, 2023 17:23
@lann lann merged commit 892ecb6 into fermyon:main Apr 5, 2023
@lann lann deleted the kv-runtime-config branch April 5, 2023 17:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants