Add more conversions to sqlite SDK ValueResult #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
itowlson
approved these changes
Aug 31, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported by @mikkelhegn where we didn't have a conversion between
ValueResultand&[u8]. This works for bothValueResult::BlobandValueResult::Text.This adds such a conversion along with conversions for all basic integer types (signed and unsigned) and
f64. It also allow casting fromValueResult::Blobto&strwhich will fail if the blob is not utf8.This is technically a breaking change as previously the conversion from
ValueResulttou32would overflow but now it returns an error: see here. I personally think this is an acceptable breaking change, but I'd like to hear others' thoughts.