Turn back on llm gpu features #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
no-all-features
branch
from
8127c82 to
eb6e873
Compare
rylev
commented
Sep 6, 2023
| @@ -115,7 +115,7 @@ jobs: | |||
|
|
|||
| - name: build release | |||
| shell: bash | |||
| run: cargo build --all-features --release ${{ matrix.config.extraArgs }} | |||
| run: cargo build --release ${{ matrix.config.extraArgs }} | |||
There was a problem hiding this comment.
Removed --all-features completely since I think we just want default features for release artifacts.
rylev
commented
Sep 6, 2023
Comment on lines
-100
to
-101
| outbound-pg-tests = [] | ||
| outbound-mysql-tests = [] |
There was a problem hiding this comment.
It looks like these were unused.
rajatjindal
reviewed
Sep 6, 2023
| @@ -41,7 +41,7 @@ jobs: | |||
|
|
|||
| - name: Cargo Clippy | |||
| run: | |||
| BUILD_SPIN_EXAMPLES=0 cargo clippy --workspace --all-targets --all-features -- -D warnings | |||
| BUILD_SPIN_EXAMPLES=0 cargo clippy --workspace --all-targets --features all-tests -- -D warnings | |||
There was a problem hiding this comment.
does this mean we are going to run clippy only for test code?
There was a problem hiding this comment.
No - features are additive so this is "all default features plus the 'all-tests' features". With --features all-tests we run clippy against strictly more code code than without it.
rajatjindal
approved these changes
Sep 6, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns back on the off-by-default features for building llm GPU support (metal and cuda based).
This tweaks CI to not build with "--all-features" but instead an "--features all-tests". In the future, we might want to consolidate our test feature flags into one feature flag.