oci: Inline small content into manifest #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
lann
force-pushed
the
oci-inline-content
branch
from
87d6e44 to
f4920cf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
lann
force-pushed
the
oci-inline-content
branch
from
f4920cf to
70b0e17
Compare
lann
changed the title
lann
commented
Sep 7, 2023
| // Update the module source with the content ref of the layer. | ||
| c.source.content = Self::content_ref_for_layer(&layer); | ||
|
|
||
| layers.push(layer); |
There was a problem hiding this comment.
I didn't bother with skipping layers here because you can't have a valid wasm file <=2 bytes and <=128 bytes is practically impossible too.
vdice
reviewed
Sep 7, 2023
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
oci-inline-content
branch
from
70b0e17 to
666eca7
Compare
vdice
approved these changes
Sep 7, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for inlining content into the spin manifest. The immediate goal is to work around a problem with OCI implementations (discussed here: distribution/distribution#4029). Additionally, inlining small content should be an overall bandwith saver as each OCI layer has to be fetched in a separate HTTP request.
This PR starts inlining small (<=128 bytes) content, but continues to also upload layers for this content unless
SPIN_OCI_SKIP_INLINED_FILESis set. Once downstream infrastructure supports content inlining we can make this the default.