upload spin linux amd64 artifacts to S3 #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
reviewed
Sep 18, 2023
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
rajatjindal
force-pushed
the
upload-release-artifacts
branch
from
251cc27 to
66c759e
Compare
|
@rajatjindal could you say more about the motivation for this? |
|
Hi Ivan, currently we download spin artifacts for internal testing purposes and those skews the GitHub statistics for the releases. so we wanted to have a different source for downloading these artifacts for internal purposes. |
|
Hi @itowlson, do you see any concerns with this or we can merge this? |
|
No, sorry, I just wanted to understand why, and now I do. Sorry for not closing the loop. |
endocrimes
approved these changes
Sep 21, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.