Reconfigure spin watch on manifest change
#1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will take a look at this when I'm back from Peru in a week and a half. |
calebschoepp
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Great work! I tested it out locally and it worked for me.
Nothing blocking on the code front. However I do think it would be helpful if you add some more comment "documentation" to some of the new constructs like ReconfigurableWatcher, RuntimeConfigFactory etc. The design wasn't immediately obvious to me and the comments you've previously added really helped.
|
Good call. There are a lot of moving parts and the names don't express well how they fit together. Thank you for taking the time to review and to test! (And I hope Peru was great!) |
itowlson
force-pushed
the
watch-reconfigure-on-manifest-change
branch
from
5a72eaf to
2d4da9c
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
watch-reconfigure-on-manifest-change
branch
from
2d4da9c to
8d7e6ec
Compare
calebschoepp
approved these changes
Oct 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This went through many extremely untidy stages and I surely need to read over it again (and do a bunch more testing), but it seems to work correctly. Yay! Now let us never speak of it again