Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

http: Make base = "/" the default #1803

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

lann
Copy link
Collaborator

@lann lann commented Sep 25, 2023

No description provided.

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeaah, this should have been the default.
LGTM!

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann force-pushed the http-base-default branch from 58a6818 to d041cc0 Compare September 25, 2023 16:06
@@ -205,6 +205,7 @@ impl From<ApplicationTrigger> for ApplicationTriggerSerialised {

/// HTTP trigger configuration.
#[derive(Clone, Debug, Deserialize, PartialEq, Eq, Serialize)]
#[serde(default)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this change do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses Self::default to set default values for any missing fields.

@lann lann merged commit 76636a8 into fermyon:main Sep 25, 2023
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants