If command matches non-installed plugin, offer install #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
vdice
reviewed
Oct 6, 2023
| warn_unsupported_version(&manifest, SPIN_VERSION, override_compatibility_check) | ||
| { | ||
| eprintln!("{e}"); | ||
| // TODO: consider running the update checked? |
There was a problem hiding this comment.
Hmmm, that could be handy. But potentially also another spot to check in with user 'no plugin manifest is found for foo, shall we update your local plugins list'? Though I think just proceeding seems like a sane default eg 'no plugin manifest is found for foo, pulling the latest available plugins from fermyon/spin-plugins...' (or other).
kate-goldenring
approved these changes
Oct 6, 2023
| if offer_install(plugin_name)? { | ||
| let plugin_installer = installer_for(plugin_name); | ||
| plugin_installer.run().await?; | ||
| eprintln!(); |
There was a problem hiding this comment.
Is this needed?
Suggested change
| eprintln!(); |
There was a problem hiding this comment.
The reason for this was to create a visual separation between the "would you like to install it" prompt and the plugin output. Without the blank line, I felt they ran together rather. But this is very subjective for sure.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user invokes a command which is not recognised, but does match a plugin, this feature offers to install that plugin:
(I am now wondering if I should print the description as part of the prompt.)
Conceptually, this PR just adds another case to the "not found" match arm in
execute_external_subcommand- there's really only a few lines of new code. But that function was getting so gnarly that I chose to break out the "make sure the plugin is there" stuff into a separate function... which was still gnarly, and anyway long story short here we are with a diff the length of your arm and yep, even now one of the functions is not free of the gnarl.