Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Handle locally installed plugin with same name and version as a registry one #1853

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Handle locally installed plugin with same name and version as a registry one #1853

merged 1 commit into from
Oct 5, 2023

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Oct 4, 2023

Fixes #1805.

It still prints two entries, but only one is shown as installed - see cloud 0.2.0 in the list below.

$ spin plugins list
ai-models 0.2.0 [installed]
check-for-update 0.0.1
check-for-update 0.1.0
cloud 0.1.0
cloud 0.1.1
cloud 0.1.2
cloud 0.2.0
cloud 0.2.0 [installed]
cloud 0.3.0
cloud-gpu 0.1.0post.1696303530 [installed]

@itowlson
Handle local plugin with same name/ver as registry
31c5365 
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson enabled auto-merge October 4, 2023 23:09
@itowlson itowlson merged commit 2269651 into fermyon:main Oct 5, 2023
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vdice vdice vdice approved these changes

@michelleN michelleN Awaiting requested review from michelleN

@mikkelhegn mikkelhegn Awaiting requested review from mikkelhegn

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spin plugin list showing two of the same version of cloud plugin installed
2 participants
@itowlson @vdice