Changes to the spin new experience
#1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
template-app-name-first
branch
from
93dd063 to
521eb19
Compare
itowlson
requested review from
michelleN,
fibonacci1729,
mikkelhegn and
kate-goldenring
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
template-app-name-first
branch
from
a7ae57b to
d9ed79b
Compare
|
@melissaklein24 I unlinked #16 because this doesn't currently address that. See #1525 (comment) and #1525 (comment) for more context on what fixing #16 would involve. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1525.
WIP: There are more changes requested in #1525, but I'm getting it under way immediately because the e2e tests useThis now has everything except the proposal to generate a blank component onspin newquite a bit and I want to know where they blow up sooner rather than later. I fixed one place but I'm sure there will be others!spin newwith no template, on which I'd like to gather more feedback before implementing. That can be a follow-up PR if necessary.And you don't know how much I wanted to call this PR "The new
newthing."