Use resources for Postgres API #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
reviewed
Oct 12, 2023
rylev
force-pushed
the
postgres-resources
branch
from
84f9823 to
bdf560f
Compare
radu-matei
approved these changes
Oct 13, 2023
rylev
force-pushed
the
postgres-resources
branch
3 times, most recently
from
55279b2 to
2f56bf2
Compare
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
postgres-resources
branch
from
2f56bf2 to
4573dce
Compare
This was referenced Oct 16, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In much the same vane as #1873 - this changes the postgres interface to use a connection oriented resource. Other than that the API is largely the same with the minor exception of removing the "success" variant on the error type (which was renamed from
pg-errortoerror).