Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: Print dirty lint paths #1903

Merged
merged 1 commit into from
Oct 17, 2023
Merged

ci: Print dirty lint paths #1903

merged 1 commit into from
Oct 17, 2023

Conversation

lann
Copy link
Collaborator

@lann lann commented Oct 17, 2023

This should make it easier to fix "Git working tree dirtied by lints".

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann requested a review from rylev October 17, 2023 15:29
@rylev
Copy link
Collaborator

rylev commented Oct 17, 2023

Just FYI: running make lint should automatically update Cargo.lock files so hopefully you shouldn't need to know which files are dirtied?

@lann
Copy link
Collaborator Author

lann commented Oct 17, 2023

Just FYI: running make lint should automatically update Cargo.lock files so hopefully you shouldn't need to know which files are dirtied?

make lint can take a long time.

@lann lann merged commit 648c5a3 into fermyon:main Oct 17, 2023
9 checks passed
@lann lann deleted the print-dirty-paths branch October 17, 2023 20:14
@itowlson
Copy link
Contributor

I had an action fail on the lints and the output was:

image

As far as I can tell, this commit was included (action was https://github.com/fermyon/spin/actions/runs/6555744599/job/17804658720, PR #1905). Should I have seen the paths needing amending?

(Yes I am running make lint now to find out what I did wrong, I am just checking in that this is the expected behaviour of the "print dirty lint paths" tweak.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants