oci: Client improvements #1911
Merged
oci: Client improvements #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lann
commented
Oct 18, 2023
lann
commented
- Make Client::pull not silently ignore some IO errors
- De-nest code in a few places
lann
commented
Oct 18, 2023
lann
commented
Oct 18, 2023
Comment on lines
+197
to
199
| if !entry.file_type().is_file() { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This is the actual change here; the rest is just indent.
lann
commented
Oct 18, 2023
Comment on lines
+238
to
+240
| if !entry.file_type().is_file() { | ||
| continue; | ||
| } |
lann
commented
Oct 18, 2023
| let _ = this.cache.write_data(&bytes, &layer.digest).await; | ||
| } | ||
| }, | ||
| return anyhow::Ok(()); |
There was a problem hiding this comment.
@vdice this was the magic that let me change the return type in here.
- Make Client::pull not silently ignore some IO errors - De-nest code in a few places Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
oci-client-improvements
branch
from
3e87847 to
ce1827a
Compare
vdice
approved these changes
Oct 18, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.