Report cargo fmt and clippy errors more quickly
#1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Oct 19, 2023
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
who-will-rid-me-of-this-turbulent-linter
branch
from
e403810 to
131265c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ifwhen I forgot to runcargo fmtI got a red mark in 2-3 minutes. It now takes 20-25 minutes. This PR proposes running lints on the core code separately from lints on the examples, so that we can get feedback more quickly in cases where the examples haven't changed (and don't need to change).This also makes the
make linttarget do "core" code only, withmake lint-allto lint, er, all. If we prefer we could keeplintas being everything and have alint-spintarget for the "core" code - I wasn't sure what people would prefer to be the default.