Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix v1 config error propagation #1951

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

fibonacci1729
Copy link
Contributor

When updating to variables I implemented the spin_world::v1::config::Host trait in terms of the variables::Host implementation. However (and i'm not sure how/why) the variables::Error (defined in variables.wit) was being propagated back to the ABI and causing a panic deep in the bowels of something. In any case, i decided to simply remapvariables::Error to a variant in spin_world::v1::config::Error which appears to correct the issue.

Signed-off-by: Brian H <brian.hardock@fermyon.com>
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Worth testing with the redirect component if you've not already done so?

@fibonacci1729
Copy link
Contributor Author

@itowlson have done so and no error so seemingly fallback kicks in as expected.

@itowlson itowlson merged commit 57fde1f into fermyon:main Oct 26, 2023
9 checks passed
@itowlson
Copy link
Contributor

@fibonacci1729 merged this because Karthik's bartholomew build hit it too, hope that's okay

@fibonacci1729 fibonacci1729 deleted the v1-config-error branch October 26, 2023 17:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants