Support v1 syntax for spin new and spin add #1953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular demand, we changed the
spin new/add
syntax in Spin 2 tospin new [NAME] [-t TEMPLATE]
.The trouble is we have a lot of content out there, such as videos and blogs, which walks people through using the v1 syntax, and would be extremely expensive to remake.
This PR introduces an ugly hack by which if a user uses the old syntax,
spin new TEMPLATE NAME
, then we spot that there are two positional args and interpret them accordingly. This does leave us in the ugly position that inspin new foo
foo is the app name and inspin new foo bar
foo is the template name but I don't know how to resolve that. It is going to be a vexing experience for people who forget the-t
because the error will be not guide them to "missing flag".The behaviour now is: