Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow for hyperium requests to be fed into router #2001

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Allow for hyperium requests to be fed into router #2001

merged 1 commit into from
Oct 31, 2023

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Oct 31, 2023

Fixes #1973 - this allows feeding a http::Request from the http crate into the router which until now only accepted spin_sdk::http::Request types.

@rylev
Allow for hyperium requests to be fed into router
38943ae 
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev requested a review from lann October 31, 2023 15:23
@rylev rylev merged commit f2bdcdb into main Oct 31, 2023
9 checks passed
@rylev rylev deleted the more-flexible-router branch October 31, 2023 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

@lann lann Awaiting requested review from lann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using the Rust SDK router with the new Request<Json<T>> type fails when calling route.handle(req);
2 participants
@rylev @fibonacci1729