Move to deny-by-default for everything but v1 SDKs and v1 manifests #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
approved these changes
Oct 31, 2023
vdice
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Can't comment on the implementation but I'm in favour of making v2 manifests deny-by-default regardless of SDK version.
Ditto ^^. Note: a quick test with the tinygo-outbound examples (eg tinygo-outbound-mysql) showed allowed-by-default behavior (v2 manifest albeit v1 interface). Perhaps this can be double-checked.
rylev
force-pushed
the
deny-by-default
branch
3 times, most recently
from
a3daa89 to
e952d35
Compare
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
deny-by-default
branch
from
e952d35 to
f4579f1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #1979 specifically implementing this idea.