Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

When translating allowed_http_hosts allow both http and htttps #2042

Merged
merged 2 commits into from
Nov 5, 2023
Merged

When translating allowed_http_hosts allow both http and htttps #2042

merged 2 commits into from
Nov 5, 2023

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Nov 3, 2023

allowed_http_hosts allowed both http and https so when translating to allowed_outbound_hosts we should respect that.

@rylev
When translating allowed_http_hosts allow both http and htttps
a69ca5c 
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@lann
Copy link
Collaborator

lann commented Nov 3, 2023

Needs more BLESS

@vdice vdice mentioned this pull request Nov 3, 2023
Merged
@lann
Copy link
Collaborator

lann commented Nov 3, 2023

FYI, this will need BLESS=1 cargo test before CI will pass.

@dicej
bless tests
af6949e 
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
vdice added a commit that referenced this pull request Nov 3, 2023
@vdice
Merge pull request #2043 from fermyon/backport-2042-to-v2.0
9672d74 
[Backport] #2042 into v2.0
@rylev rylev merged commit 008546b into main Nov 5, 2023
9 checks passed
@rylev rylev deleted the allow-http-and-https branch November 5, 2023 03:04
@melissaklein24 melissaklein24 added this to the 2.1 milestone Dec 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lann lann lann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@rylev @lann @melissaklein24 @dicej