Include trigger type in trigger options help header #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
karthik2804
approved these changes
Jan 29, 2024
rylev
approved these changes
Jan 29, 2024
| @@ -255,6 +255,12 @@ fn warn_if_wasm_build_slothful() -> sloth::SlothGuard { | |||
| sloth::warn_if_slothful(SLOTH_WARNING_DELAY_MILLIS, format!("{message}\n")) | |||
| } | |||
|
|
|||
| fn help_heading<E: TriggerExecutor>() -> Option<&'static str> { | |||
| let heading = format!("{} TRIGGER OPTIONS", E::TRIGGER_TYPE.to_uppercase()); | |||
| let as_str = Box::new(heading).leak(); | |||
There was a problem hiding this comment.
Using Box::leak is fine here IMO, but I think perhaps using a static and OnceCell is another, arguably less hacky, solution.
There was a problem hiding this comment.
Agreed; leak is perfectly fine for this purpose.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2252.
Note this does not deduplicate common options - it only adds the trigger type as part of the section header.