Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Work around hyper graceful shutdown bug #232

Conversation

itowlson
Copy link
Contributor

IT WORKS ON WSL AND NOW I AM GOING TO HAVE A GLASS OF WINE

@itowlson itowlson requested a review from radu-matei March 24, 2022 05:34
@itowlson
Copy link
Contributor Author

Fixes #73.

Knew there was something.

@itowlson
Copy link
Contributor Author

Note that although the server shutdown is not "graceful" in this case, the program shutdown still is - and that is what we need to clean up the temp directories.

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested on a Mac, this seems to work!

Wow, this was SO annoying, thank you for finding the solution for it!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants