Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes #925 in order to remove the hard-coded parameter$\lambda_{abs}$ . With this change, the definition of $k_{bs}$ in theory (as a rate constant) will be correct.
Additionally,
J_vs
,k_bs
, andk_sb
now acceptmobile
cocnentration by default allowing to account for fluxes that might depend on the concentration of subsurface H atoms (see Baskes 1980, Richards 1988, Pisarev 1997).Types of changes
What types of changes does your code introduce to FESTIM?
Checklist