Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[US15] Deletar ajuda #138

Closed
2 tasks
EsioFreitas opened this issue Apr 20, 2021 · 1 comment · Fixed by Lend-it/Request#25 or Lend-it/Gateway#18
Closed
2 tasks

[US15] Deletar ajuda #138

EsioFreitas opened this issue Apr 20, 2021 · 1 comment · Fixed by Lend-it/Request#25 or Lend-it/Gateway#18
Assignees
@Thais-ra @mateusmaiamaia @thiagompc
Labels
BACK HARD MDS Time de Métodos de Desenvolvimento de Software US
Milestone
Sprint 12

Comments

@EsioFreitas
Copy link
Member

Descrição da Issue

Lend.it deseja deletar uma solicitação de empréstimo que não foi atendida por outro usuário para | não manter registros

Tasks:

  • Criar serviço no back

Critérios de Aceitação:

  • Lend.it deve conseguir deletar uma lend que acabou o tempo
@EsioFreitas EsioFreitas added BACK MDS Time de Métodos de Desenvolvimento de Software US HARD labels Apr 20, 2021
@EsioFreitas EsioFreitas added this to the Sprint 11 milestone Apr 20, 2021
@lucasdutraf lucasdutraf changed the title [US15] deletar ajuda [US15] Deletar ajuda Apr 20, 2021
@lucasdutraf
Copy link
Member

@mateusmaiamaia @Thais-ra @thiagompc

Lembrem-se do seguinte: A issue de vocês também contempla a refatoração desses 3 endpoints e seus respectivos testes.

https://github.com/Lend-it/Request/blob/devel/project/api/views.py#L56

https://github.com/Lend-it/Request/blob/devel/project/api/views.py#L93

https://github.com/Lend-it/Request/blob/devel/project/api/views.py#L116

Conferir no frontend as rotas utilizadas, mas a ideia é:

  • A filtragem por end_date ser aplicada em todas elas
  • A filtragem pelo requester diferente do passado para o endpoint
  • A filtragem pelo lender passado pelo endpoint

A abordagem a ser utilizada cabe a vocês! Existe uma redundância nessas rotas mas vou deixar livre para vocês utilizarem suas ferramentas e concluírem o que faz sentido e respeita as regras de responsabilidade de código! 😸

Thais-ra added a commit to Lend-it/Request that referenced this issue Apr 23, 2021
@Thais-ra @thiagompc @mateusmaiamaia
feat: fga-eps-mds/2020.2-Lend.it#138 Added end date as filter in the …
1e028ac 
…get_all_available_requests

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
Thais-ra added a commit to Lend-it/Request that referenced this issue Apr 23, 2021
@Thais-ra @thiagompc @mateusmaiamaia
refactor: fga-eps-mds/2020.2-Lend.it#138 Refactored get requests filt…
38d8ece 
…ered by category route

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
Thais-ra added a commit to Lend-it/Request that referenced this issue Apr 23, 2021
@Thais-ra @thiagompc @mateusmaiamaia
refactor: fga-eps-mds/2020.2-Lend.it#138 Refactored get requests filt…
7485545 
…ered by category route

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
Thais-ra added a commit to Lend-it/Request that referenced this issue Apr 24, 2021
@Thais-ra @thiagompc @mateusmaiamaia
refactor: fga-eps-mds/2020.2-Lend.it#138 Refactored get requests filt…
d2f1ce8 
…ered by category route

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
Thais-ra added a commit to Lend-it/Request that referenced this issue Apr 24, 2021
@Thais-ra @thiagompc @mateusmaiamaia
test: fga-eps-mds/2020.2-Lend.it#138 Route and name changed in the te…
1563bfa 
…st get requests filtered by category

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
Thais-ra added a commit to Lend-it/Request that referenced this issue Apr 24, 2021
@Thais-ra @thiagompc @mateusmaiamaia
test: fga-eps-mds/2020.2-Lend.it#138 Created test for get all availab…
8b7263d 
…le requests and not available requests

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Thais-ra Thais-ra mentioned this issue Apr 24, 2021
Merged
7 tasks
thiagompc pushed a commit to Lend-it/Gateway that referenced this issue Apr 29, 2021
@Thais-ra @mateusmaiamaia
@youssef-md @viniciussaturnino
feat: fga-eps-mds/2020.2-Lend.it#138 Connect gateway with request fil…
618d3bd 
…ter available requests by category

Co-authored-by: Thais Reboucas <rotinasoftware@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
Co-authored-by: Youssef Muhamad <emaildeyoussefmuhamad@gmail.com>
Co-authored-by: Vinicius Saturnino <viniciussaturnino78@gmail.com>
lucasdutraf added a commit to Lend-it/Request that referenced this issue Apr 29, 2021
@lucasdutraf @Thais-ra
@thiagompc @mateusmaiamaia
perf: fga-eps-mds/2020.2-Lend.it#138 Update datetime now method
8316ace 
Co-authored-by: Thais Reboucas <rotinasoftware@gmail.com>
Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Thais-ra Thais-ra mentioned this issue Apr 30, 2021
Merged
7 tasks
@rogerioo rogerioo removed this from the Sprint 11 milestone May 24, 2021
@rogerioo rogerioo added this to the Sprint 12 milestone May 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Thais-ra Thais-ra

@mateusmaiamaia mateusmaiamaia

@thiagompc thiagompc

Labels
BACK HARD MDS Time de Métodos de Desenvolvimento de Software US
Projects
None yet
Milestone
Sprint 12
7 participants
@lucasdutraf @EsioFreitas @Thais-ra @rogerioo @mateusmaiamaia @viniciussaturnino @thiagompc